Fix parameter type ordering #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now, the parameter types were obtained by calling `.values()` on the HashSet of parameter types, but this leads to unpredicable ordering, causing queries to fail because their parameters were often transposed. Instead, sort the parameter types by their names. This should always work because in the postgresql case, the keys are '$1', '$2', etc.
sunng87
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, the parameter types were obtained by calling
.values()on the HashSet of parameter types, but this leads to unpredicable ordering, causing queries to fail because their parameters were often transposed.Instead, sort the parameter types by their names. This should always work because in the postgresql case, the keys are '$1', '$2', etc.